Skip to content

[FEATURE]: Publish estimates as TwistWithCovarianceStamped to support estimators #7

Open

Description

@evan-palmer

Feature Type

Adding new functionality to the project

Problem Description

The current implementation publishes the state information using the marine_msgs DVL message. This should continue to be used. However, this message is not accepted by various estimators supported by ROS.

Feature Description

Create a new second publisher, which publishes the velocity estimates transformed into the appropriate coordinate frame and as a TwistWithCovarianceStamped. This will ensure that estimators such as the robot_localization and fuse can interpret the message.

Alternative Solutions

I need to verify that the model used by fuse will accept this message type. The message type supported by fuse should be preferred over the robot_localization message type as the robot_localization package has been deprecated in favor of fuse.

Additional Context

No response

Activity

  1. rakeshv24 commented on Nov 15, 2024

    @rakeshv24

    @evan-palmer is the expected coordinate frame for the estimators base_link or base_link_fsd?

  2. evan-palmer commented on Nov 15, 2024

    @evan-palmer
    ContributorAuthor

    This would be base_link

  3. rakeshv24 commented on Nov 15, 2024

    @rakeshv24

    Also, TwistWithCovariance is part of Odometry. Do we still need a separate publisher?

  4. evan-palmer commented on Nov 15, 2024

    @evan-palmer
    ContributorAuthor

    Oh I completely forgot that I added that. Maybe we should put the existing publisher on the odom_fsd frame and the new one on odom. We should double check how Fuse handles transforms. If it expects everything to be at the base frame, we might also want to think about a way to apply the adjoint transformation to that frame

  5. rakeshv24 commented on Nov 15, 2024

    @rakeshv24

    Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions