Skip to content
This repository was archived by the owner on Jun 27, 2019. It is now read-only.
This repository was archived by the owner on Jun 27, 2019. It is now read-only.

Typo in: selenium driver fixture; load firefox from profile  #124

Open

Description

@wvanmourik

At the moment, the code is:
public void loadFirefoxProfileFromDirectory(String directory) {
defaultWebDriverSupplier.setCustomProfilePreferencesFile(new File(directory));
}

It should be:
public void loadFirefoxProfileFromDirectory(String directory) {
defaultWebDriverSupplier.setProfileDirectory(new File(directory));
}

I am guessing this typo is an copy/paste error from function:
public void loadCustomBrowserPreferencesFromFile(String filename) {
defaultWebDriverSupplier.setCustomProfilePreferencesFile(new File(filename));
}

Activity

  1. jguglielmi commented on May 7, 2014

    @jguglielmi

    Similar to #106 ?

  2. raboof commented on May 7, 2014

    @raboof
    Contributor

    That indeed looks like a clear mistake. Should be fixed, but as I don't use this functionality, could you test whether this indeed now works?

  3. wvanmourik commented on May 8, 2014

    @wvanmourik
    Author

    Hi Jaison,

    Almost, but not really. It seems you want a different functionality, while
    I just wanted the existing functionality to work.
    The issue is basically solved seeing the comment from raboof.

    The file not found errors you got before, were because of this bug. I had
    those too and that is how I found this typo.
    Likely you can use the now fixed code and use multiple Firefox profiles by
    passing a directory.

    Example:
    |load firefox profile from directory|
    FitnesseRoot\files\BrowserProfiles\Firefox\myprofilename|

  4. jguglielmi commented on May 8, 2014

    @jguglielmi

    Gotcha.

  5. jguglielmi commented on May 8, 2014

    @jguglielmi

    I was just using the setProfileDirectory method directly with the String implementation when I declared my default web driver supplier as a variable. Where as you described it was then passed into the File instance of the method which called setProfileDirectory. Thanks for @mourikwa! This should close #106 as well. I'll go ahead and tidy up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions