Skip to content

pin setup-uv to a commit sha across downstream jobs - #1213

Merged
agronholm merged 2 commits into
agronholm:masterfrom
EmmanuelNiyonshuti:pin-setup-uv-sha
Jul 10, 2026
Merged

agronholm merged 2 commits into
agronholm:masterfrom
EmmanuelNiyonshuti:pin-setup-uv-sha

Conversation

@EmmanuelNiyonshuti

Copy link
Copy Markdown
Collaborator

NOTE Erasing or replacing the contents of this template will result in your pull
request being summarily closed without consideration!

Changes

Fixes #.

Downstream jobs that use astral-sh/setup-uv, only one (FastAPI) was pinned to a commit sha, the others used a floating tag. I'm pinning all four to the same commit hash. Minor thing, but keep consistency across these jobs. (more about setup-uv immutable releases and secure tags).
They're all now on the exact same version too!

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) which would fail without your patch
  • You've updated the documentation (in docs/), in case of behavior changes or new
    features
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

- Fix big bad boo-boo in task groups
  (`#123 <https://github.com/agronholm/anyio/issues/123>`_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@agronholm

Copy link
Copy Markdown
Owner

If anything, I would prefer all downstream tests to be done against the latest versions. When this workflow is triggered, it should tell us if the target AnyIO version works with the latest downstream, not some arbitrary version of the past.

@EmmanuelNiyonshuti

EmmanuelNiyonshuti commented Jul 9, 2026 •

Copy link
Copy Markdown
Collaborator Author

all downstream(those using setup-uv action) are on 8.2.0 but the latest is 8.3.2 . on uv version though, I did not pin it to the latest version. for example fastapi is currently on "0.11.18" version of uv while actually the latest is "0.11.28" we seem to have 0.11.4 pinned version, I could pin it to the version fastapi is on or the latest uv version, there is a small concern here , setup-uv action verifies checksums for uv versions it already knows about at the time it was released at least before astral-sh/setup-uv#919 is addressed. but this is manually triggered anyway.
Do you mean we need to pin the setup-uv action to the latest version, pin uv to the latest or both? Aside from fastapi, all pinned uv versions we have match the exact downstream pinned versions.

@EmmanuelNiyonshuti

Copy link
Copy Markdown
Collaborator Author

I leaned more toward keeping version pins mirroring downstream's own pins. Not that using the latest versions would necessarily break anything, but I didn't want to have this testing compatibility with anyio using a uv version downstream's own tests have never run on.

@agronholm

agronholm commented Jul 9, 2026 •

Copy link
Copy Markdown
Owner

Ah, I think there was a misunderstanding on my part. I really shouldn't be replying to issues this late in the evening, but I do non-Python work during working hours 😅
So yes, syncing uv versions with downstream is totally fine. My mind somehow read that as pinning the downstream projects themselves.

@EmmanuelNiyonshuti

Copy link
Copy Markdown
Collaborator Author

Ah, I think there was a misunderstanding of my part. I really shouldn't be replying to issues this late in the evening, but I do non-Python work during working hours 😅 So yes, syncing uv versions with downstream is totally fine. My mind somehow read that as pinning the downstream projects themselves.

😅 Your reply actually made me revisit the setup-uv side of things and double-check my assumptions. I was updating the uv pins in another project earlier today, my mind immediately went there. I'll update FastAPI's uv version to match its downstream pin; since others already match.

@agronholm agronholm left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@agronholm
agronholm merged commit 44713f3 into agronholm:master Jul 10, 2026
6 checks passed
@EmmanuelNiyonshuti
EmmanuelNiyonshuti deleted the pin-setup-uv-sha branch July 11, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants