Repository navigation
pin setup-uv to a commit sha across downstream jobs - #1213
Conversation
|
If anything, I would prefer all downstream tests to be done against the latest versions. When this workflow is triggered, it should tell us if the target AnyIO version works with the latest downstream, not some arbitrary version of the past. |
|
all downstream(those using setup-uv action) are on 8.2.0 but the latest is 8.3.2 . on uv version though, I did not pin it to the latest version. for example fastapi is currently on "0.11.18" version of uv while actually the latest is "0.11.28" we seem to have 0.11.4 pinned version, I could pin it to the version fastapi is on or the latest uv version, there is a small concern here , setup-uv action verifies checksums for uv versions it already knows about at the time it was released at least before astral-sh/setup-uv#919 is addressed. but this is manually triggered anyway. |
|
I leaned more toward keeping version pins mirroring downstream's own pins. Not that using the latest versions would necessarily break anything, but I didn't want to have this testing compatibility with anyio using a uv version downstream's own tests have never run on. |
|
Ah, I think there was a misunderstanding on my part. I really shouldn't be replying to issues this late in the evening, but I do non-Python work during working hours 😅 |
😅 Your reply actually made me revisit the |
NOTE Erasing or replacing the contents of this template will result in your pull
request being summarily closed without consideration!
Changes
Fixes #.
Downstream jobs that use astral-sh/setup-uv, only one (FastAPI) was pinned to a commit sha, the others used a floating tag. I'm pinning all four to the same commit hash. Minor thing, but keep consistency across these jobs. (more about setup-uv immutable releases and secure tags).
They're all now on the exact same version too!
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchdocs/), in case of behavior changes or newfeatures
docs/versionhistory.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.