Skip to content

funcalign: Add RSRM compatibility with scikit-learn >=0.24 #491

Closed

Description

@mihaic

Starting with version 0.24, scikit-learn enforces the requirement to set parameters passed to estimators as instance attributes:

Fix base.BaseEstimator.get_params now will raise an AttributeError if a parameter cannot be retrieved as an instance attribute.
https://scikit-learn.org/stable/whats_new/v0.24.html#sklearn-base

RSRM has a gamma parameter, but it does not set a gamma attribute; instead it stores the value in the lam attribute:
https://github.com/brainiak/brainiak/blob/master/brainiak/funcalign/rsrm.py#L111

The resulting error shows up in our tests:
https://travis-ci.org/github/brainiak/brainiak/jobs/759097966#L866

Should we rename lam to gamma?

Activity

  1. assigned and unassigned on Feb 17, 2021
  2. TuKo commented on Feb 17, 2021

    @TuKo

    Yes, renaming it should be fine. Just created a PR

  3. added a commit that references this issue on Feb 19, 2021
    c2f02e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions