Repository navigation
Update to eventseg - #266
Conversation
…n notebook eventseg example, also updated download link in isfc example
mihaic
left a comment
There was a problem hiding this comment.
Great looking tutorial! So far, we have been committing example code without outputs, for ease of tracking changes. Clearly it is helpful to have the outputs visible on the web. I will merge your PR (after you address the minor comment) and try to solve the problem in issue #268.
|
|
||
| if var is None: | ||
| var = self.event_var_ | ||
| if self.event_var_ is None: |
There was a problem hiding this comment.
The test should check the existence of the attribute, not whether it is None. The documentation is not perfectly clear, but the code is:
the existence of parameters with trailing _ is used to check if the estimator has been fitted.
http://scikit-learn.org/stable/developers/contributing.html#parameters-and-init
if not all_or_any([hasattr(estimator, attr) for attr in attributes]):
raise NotFittedError(msg % {'name': type(estimator).__name__})https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/utils/validation.py#L793
|
You should also update the paper reference to point to Neuron. |
Minor update to eventseg to support additional use case, added ipython notebook eventseg example, also updated download link in isfc example