Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lunarmodules/busted
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: hishamhm/busted
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 3 contributors

Commits on May 30, 2014

  1. Do not abort on non-string errors

    Commit a62819e only addresses tables. Any other error not coerced to string, in
    particular nil, can bust busted. The following test exposes the problem:
    
    describe('busted', function ()
        it('must handle any error value', function () error() end)
    end)
    
    and results in:
    
    [...]/utf_terminal.lua:22: attempt to concatenate field 'err' (a nil value)
    
    This patch forcibly converts err to tostring(err) if it is not string or a
    table onthe core side.
    ntd committed May 30, 2014
    Configuration menu
    Copy the full SHA
    3edf46f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #244 from ntd/pr1

    Do not abort on non-string errors
    ajacksified committed May 30, 2014
    Configuration menu
    Copy the full SHA
    efb8b2a View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2014

  1. Use LuaRocks's own wrapper for scripts

    When installing via LuaRocks, the busted shell script and batch file fail to find busted_bootstrap (or rather, they find LuaRocks's own wrapper, and loading it fails because it is a shell script itself.) Simplifying the rockspec like this enables to use LuaRocks's own wrapper directly, and paths are properly setup.
    hishamhm committed Jun 3, 2014
    Configuration menu
    Copy the full SHA
    1c79a46 View commit details
    Browse the repository at this point in the history
Loading