isc: phaseshift_isc overlaps with brainiak.utils.phase_randomize #396

Activity

1. mihaic

   assigned

   snastase

   on Dec 17, 2018
2. mihaic

   added this to the v0.9 milestone on Jan 11, 2019
3. snastase commented on Mar 3, 2019

   

   snastase

   on Mar 3, 2019

   Last edited by snastase

   Contributor

   More actions

   These are not really functional duplicates. I think in theory what we want is (a) phaseshift_isc, which performs the nonparametric test using phase randomization and returns a null distribution, p-values, etc; and (b) a more generic phase_randomize utility that simply takes in time-series and phase-randomizes them. I think having this phase_randomize utility is useful even outside the context of ISC analysis. And ideally, the phaseshift_isc function should use the phase_randomize function internally. This was a little tricky because the pairwise and leave-one-out ISC approaches apply the phase randomization slightly differently, but should be work now—see #405 (commit dba670a). I've updated phaseshift_isc in isc, utils and tests to match.
4. snastase

   closed this as completedon Mar 27, 2019
5. mihaic commented on Mar 27, 2019

   

   mihaic

   on Mar 27, 2019

   MemberAuthor

   More actions

   There's a way to close issues with commit messages such that it is clear they were fixed. I think we should use it in the future:
   https://help.github.com/articles/closing-issues-using-keywords/