Repository navigation
Fix bugs before major pull request is approved - #197
Merged
Merged
Conversation
…nge in last November. Fixed the bug in posterior estimation of betas since the review of the major pull request might take longer.
Member
|
Please follow the naming convention for modules, even for example files, and even for notebook files: You could use |
Contributor
Author
|
Done. |
mihaic
approved these changes
Mar 22, 2017
CameronTEllis
pushed a commit
to CameronTEllis/brainiak
that referenced
this pull request
May 12, 2017
* a Changes to be committed: new file: brainiak/brsa/test.txt * deleted: brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * deleted: brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * deleted: brsa/test.txt * deleted: brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * deleted: brsa/test.txt * deleted: brsa/test.txt * deleted: brsa/test.txt * deleted: brsa/test.txt * Changed all usage of scipy.linalg.block_diag in accordance to its change in last November. Fixed the bug in posterior estimation of betas since the review of the major pull request might take longer. * reduce testing time for brsa * renamed BRSA example * rename brsa example
mihaic
pushed a commit
that referenced
this pull request
May 12, 2017
* Substantial edits to how noise is calculated. Some edits to how noise is created. Altered test and example to suit update * pep8 update * Made _calc_fwhm less complex * Update for edits * [reprsimil] Fix BRSA bugs (#197) * a Changes to be committed: new file: brainiak/brsa/test.txt * deleted: brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * deleted: brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * deleted: brsa/test.txt * deleted: brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * a Changes to be committed: new file: brainiak/brsa/test.txt * deleted: brsa/test.txt * deleted: brsa/test.txt * deleted: brsa/test.txt * deleted: brsa/test.txt * Changed all usage of scipy.linalg.block_diag in accordance to its change in last November. Fixed the bug in posterior estimation of betas since the review of the major pull request might take longer. * reduce testing time for brsa * renamed BRSA example * rename brsa example * [dev] Fix LDFLAGS for LLVM on MacOS * _calc_snr turned into _calc_sfnr with the necessary changes associated with it. Improves accuracy of noise modelling * Pep8 errors corrected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the pull request of adding GBRSA and score/transform function can take a while, I want to have this minor pull request while the major one is being reviewed.