Skip to content

Restrict multiprocessing to available CPUs - #293

Merged
mihaic merged 1 commit into
brainiak:masterfrom
mihaic:respect-cpuset
Nov 8, 2017
Merged

mihaic merged 1 commit into
brainiak:masterfrom
mihaic:respect-cpuset

Conversation

@mihaic

@mihaic mihaic commented Nov 7, 2017

Copy link
Copy Markdown
Member

See issue #291.

@yidawang yidawang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me for the FCMA part. I would approve if the Searchlight part looks good, too.

@mjanderson09 mjanderson09 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this impact performance?

@mihaic

mihaic commented Nov 8, 2017

Copy link
Copy Markdown
Member Author

Good question, @mjanderson09. I see no reason for performance to change. In practice, I see the same the same performance on genre_searchlight_example with pool_size=None:

# before
Searchlight Done:  4.976254463195801
# after
Searchlight Done:  4.268961191177368

@mihaic
mihaic merged commit 21aa882 into brainiak:master Nov 8, 2017
@mihaic
mihaic deleted the respect-cpuset branch November 8, 2017 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants