Skip to content

dev: Configure coverage for multiprocessing #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielsuo merged 5 commits into from
Feb 3, 2018
Merged

dev: Configure coverage for multiprocessing #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a9d825
dev: Configure coverage for multiprocessing
mihaic Feb 2, 2018
9d20aa4
Coverage does not always produce empty files
mihaic Feb 2, 2018
1682df4
Add Codecov integration
mihaic Feb 2, 2018
d699ee1
Disable run-tests coverage error to enable Codecov
mihaic Feb 2, 2018
1a2fd80
Disable Codecov comments
mihaic Feb 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
comment: false
4 changes: 3 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ matrix:
before_install: *macos_before_install

install:
- python3 -m pip install -U pip
- python3 -m pip install -U pip codecov

script:
- ./pr-check.sh
after_success:
- codecov
1 change: 0 additions & 1 deletion pr-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ function exit_with_error {
function exit_with_error_and_venv {
$deactivate_venv
cd $basedir
rm -f .coverage.*
$remove_venv $venv
exit_with_error "$1"
}
Expand Down
6 changes: 4 additions & 2 deletions run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ then
fi
$mpi_command -n 2 coverage run -m pytest

# Coverage produces empty files which trigger warnings on combine
find . -name ".coverage.*" -size 0 -print0 | xargs -0 rm -f

coverage combine

# Travis error workaround
Expand All @@ -58,6 +61,5 @@ rm $coverage_report

if [ $report_exit_code = 2 ]
then
echo "ERROR: Coverage too low."
echo "WARNING: Coverage too low."
fi
exit $report_exit_code
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ ignore =
[coverage:run]
source = brainiak
branch = True
concurrency = multiprocessing
parallel = True

[coverage:report]
Expand Down