Repository navigation
Add Conda packaging - #328
Conversation
mihaic
left a comment
There was a problem hiding this comment.
Looks good. I will add the documentation.
| @@ -0,0 +1,10 @@ | |||
| :: NOTE: Windows not supported! | |||
|
Don't believe so; it was automatically generated. I'm testing now whether
we need it to build.
…On Fri, Feb 2, 2018 at 1:18 PM, Mihai Capotă ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Looks good. I will add the documentation.
------------------------------
In .conda/bld.bat
<#328 (comment)>:
> @@ -0,0 +1,10 @@
+:: NOTE: Windows not supported!
Is this script necessary?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#328 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACkV1h7nk2O6EprA05VMKJDnSIq8oI3Kks5tQ1GBgaJpZM4R3SMX>
.
|
|
Ok, initially looks good; not sure about code coverage or hanging tests though. It'll be good to get wider user testing before we make a more public change. |
|
@danielsuo, can you please add to CONTRIBUTING instructions for uploading Conda package? |
|
Sounds good; should this go in ```Making a release```?
…On Fri, Feb 2, 2018 at 5:49 PM, Mihai Capotă ***@***.***> wrote:
@danielsuo <https://github.com/danielsuo>, can you please add to
CONTRIBUTING instructions for uploading Conda package?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#328 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACkV1iFotPwOF72u43MbdqTRhh3K0t9hks5tQ5DpgaJpZM4R3SMX>
.
|
|
Yes. |
|
I was unsure of how to organize the process since there's a for loop
involved for OS / python versions, but put something up.
…On Fri, Feb 2, 2018 at 5:52 PM, Mihai Capotă ***@***.***> wrote:
Yes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#328 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACkV1uQB-yC_S-18YvMZ4MbliBGbYcPKks5tQ5GygaJpZM4R3SMX>
.
|
|
I propose we update the website after making the release. As far as I understand, we do not need The MacOS requirements situation is less clear to me. @danielsuo, if you have access to a MacOS VM, can you try installing the package without first installing Xcode? I uploaded one to my channel: With the new compilers all tests are passing. Finally, we will upload to the |
Create Conda packages and test in Travis. A few outstanding issues
test_brsa.pyfor Travis, but not anywhere else linkapt install build-essentialorxcode-select installUnrelated issues: code coverage (see #327 and #326).