Repository navigation
dev: Pin scikit-learn <0.22 to fix fcma test - #450
Merged
Merged
Conversation
See issue brainiak#448. Also, pin NumPy in `setup_requires` as well.
CameronTEllis
approved these changes
Dec 11, 2019
CameronTEllis
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just need to remember to review in a few months
Member
Author
|
Thanks. I created a milestone for v0.11 and added the issue there so we don't forget. Now we only need to remember to check the milestone before releasing. :) |
Required for compatibility with our testing infrastructure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #448.
Also, pin NumPy in
setup_requiresas well.