Repository navigation
Split-merge - #451
Split-merge#451
Conversation
Update fork
…-likelihood is symmetric
|
Jenkins is failing with "salloc: error: Job submit/allocate failed: Unable to contact slurm controller (connect failure)" - looking through my emails I think slurm is down for maintenance at Princeton today, can a maintainer please restart the checks once it is back up? Edit: The macos build is failing with an error related to TFA: "Warning, treated as error: |
|
@cbaldassano, thanks for the heads up. We are working of fixing the problems. @qihongl, you can see on Travis that the unit tests are passing, so please disregard the failures and review as soon as possible. |
|
I would be happy to review this! @cbaldassano @qihongl |
|
Indeed, the build error was an unrelated. Should be fixed. @cbaldassano, could you please also write a blurb for the release notes? See this old one if you need to refresh your memory on how they work: |
|
Done! |
|
Thank you for your contributions, @cbaldassano and @tsy6! |
This pull request implements an improvement to the fitting procedure for the HMM, allowing for re-allocating events during fitting with a split-merge operation. This behavior is disabled by default so as not to break backwards compatibility and because it adds additional computation time, but can be enabled using the new split_merge flag in the constructor.
A draft of a blog post explaining the logic behind this change and some example fits can be found here: http://chrisbaldassano.com/Split-Merge.mhtml