Skip to content

fix!: support Go 1.27 compiler export data - #4

Merged
dominicnunez merged 1 commit into
mainfrom
fix/stable-go-types
Oct 30, 2026
Merged

dominicnunez merged 1 commit into
mainfrom
fix/stable-go-types

Conversation

@dominicnunez

Copy link
Copy Markdown
Owner

Gallow exits with internal error: package "errors" without types was imported when analyzing compiler export data generated by Go 1.27.3. Update golang.org/x/tools and its required module dependencies so standard-library imports load correctly and live/dead-code findings remain available.

Source builds now require Go 1.26 because the compatible upstream dependencies require it. The README documents this breaking change. CI tests the supported Go 1.26 line and pinned current stable Go 1.27.3.

Validation:

  • A new public Analyze regression importing errors/fmt failed against the prior dependency and passes after the upgrade, in production and test-loading modes; it requires the dead function finding and excludes a finding for the live function.
  • Full race suites pass on Go 1.27.3 and Go 1.26.10.
  • Ordinary tests, formatting, dependency consistency/verification and build pass on Go 1.27.3; vet and clean Gallow self-analysis pass on both compiler lines.
  • Independent source review found no actionable issues.

This is a required dependency for the owner's Game Over paper engine. It does not change that project's pinned compiler or authorize live orders.

Upgrade the analysis dependencies and exercise compiler-produced standard-library export data in production and test modes.

BREAKING CHANGE: building Gallow requires Go 1.26 or newer.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T16:05:55.247754Z f8c211a PR opened
🔒 Security Review ✅ Completed 2026-10-30T16:10:38.898599Z f8c211a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dominicnunez

Copy link
Copy Markdown
Owner Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: f8c211a4e6

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@dominicnunez
dominicnunez merged commit 8242a4b into main Oct 30, 2026
7 checks passed
@dominicnunez
dominicnunez deleted the fix/stable-go-types branch October 30, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant