Repository navigation
fix: track uses of instantiated generic fields - #5
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gallow reported used fields on instantiated generic types as unused because Go supplies distinct field objects for the instantiated types. Field uses now resolve to their original declaration object in both identifier and selector indexes, preserving object identity across packages and promoted fields.
Regressions cover generic value and function fields, keyed initializers, method bodies, promoted fields through an imported type alias, and genuinely unused fields with matching names. The prior revision fails the new regression.
Validation on Go 1.27.3: full race suite, vet, build, dependency checks, and Gallow self-analysis pass. The patched analyzer also reports zero findings against the Game Over worktree that exposed the defect. Independent patch review found no outstanding findings. CI also exercises the supported Go 1.26 line.
Refs dominicnunez/game-over#22.