Repository navigation
fix: stabilize duplicate finding fingerprints - #7
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unchanged duplicate finding can receive a different fingerprint when unrelated groups alter the unstable ordering of equal-location candidates. Break those ties by content key so exact exceptions and baselines remain stable as unrelated clones are added.
Adds a failing-before/passing-after coalescer regression and public Analyze stability coverage. Thresholds and merge rules are unchanged. Correcting the old tie order can change affected fingerprints once; the README documents reviewing refreshed exact exceptions.
Validation: Go 1.27.3 formatting, tidy diff, module verification, vet, full race tests, build, and self-Gallow CI scan passed. The regression fails against the original production code; consumer CLI diagnostics also retain the original identity after the fix. CI additionally covers Go 1.26.x.
Closes #6.