Repository navigation
struct: preserve embedded values in non-unique sections - #421
Closed
Narek-Khachikyan wants to merge 1 commit into
Closed
Narek-Khachikyan wants to merge 1 commit into
Narek-Khachikyan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
ReflectFromwrites embedded fields into the first matching section, so the secondBigSlotoverwrites the first slot's ID and loses its own. Keep nested fields in the current section occurrence when the section names match.The regression calls
ReflectFromandWriteToin memory. Before the fix, it produces ID 4 with blue and no ID with red. After the fix, it produces ID 3 with blue and ID 4 with red.Proof:
go test -v -race ./...,go vet ./..., andgolangci-lint run --timeout=30mpass. Formatting checks are clean.Fixes #327.
Checklist