You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Knip is an awesome tool that let's you know about unused deps/exports in the codebase, unused exports shouldn't be a worry of ours when it comes to the ui package but otherwise it does apply.
I had started looking at the implementation for this this afternoon, but I am currently facing some issues.
It fails to resolve the storybook configuration found in packages/config/storybook/src/configs/react-vite.ts that is a dependent of packages/ui/.storybook/main.ts as I can only assume knip expects all packages to be built before the command runs, which isn't ideal.
It fails to resolve the .css file located in the assets package, @orbitkit/assets/fonts/stylesheet.css for example, specifically when parsing apps/marketing/src/components/BaseHead.astro.
It finally fails to recognise the multiple eslint plugins that are used and marks them as unused, perhaps because of the monorepo nature!
I'm going to attempt to work through these following the suggestions in the documentation, but I'm hitting a couple of hurdles.
Activity
msmps commentedon Apr 7, 2024
I had started looking at the implementation for this this afternoon, but I am currently facing some issues.
packages/config/storybook/src/configs/react-vite.tsthat is a dependent ofpackages/ui/.storybook/main.tsas I can only assume knip expects all packages to be built before the command runs, which isn't ideal.@orbitkit/assets/fonts/stylesheet.cssfor example, specifically when parsingapps/marketing/src/components/BaseHead.astro.I'm going to attempt to work through these following the suggestions in the documentation, but I'm hitting a couple of hurdles.