Repository navigation
\#tag fix attempt #2 - #141
Merged
Merged
Conversation
This adds a check for an escape tokens just before matching the `#tag` check.
Contributor
Author
|
|
Member
|
Ah, yup, this looks like a much better approach, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was difficult to research exactly how to use Ace's highlighting system, but I believe this close to the proper way.
One improvement would be to move this escape sequence out to... someplace, but I have no idea where it should go. I tried putting it after the comment section, but no dice.
Someone who knows more than I do can make a more general purpose escape token, but this should work for this specific instance.