Repository navigation
Conversation
Sorting dashboard metrics in descending order places rows with null or undefined metrics ahead of measured values, obscuring the highest values. Use -1 as the sort value for missing entries in numeric columns. This places missing metrics below zero in both sort directions while retaining real zero measurements and leaving nonnumeric column sorting unchanged. Validated with all 96 JavaScript tests across 15 suites, ESLint for BaseTable.jsx, and git diff --check. The new regression test fails on the original code and checks both sort directions, including zero values. Fixes linkerd#3874 Signed-off-by: Mohammed Sharooq <sharooqlavanya04@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting dashboard metrics in descending order places rows with null or
undefined metrics ahead of measured values, obscuring the highest values.
Use
-1as the sort value for missing entries in numeric columns. Thisplaces missing metrics below zero in both sort directions while retaining
real zero measurements and leaving nonnumeric column sorting unchanged.
Validated with all 96 JavaScript tests across 15 suites, the webpack build
(including ESLint), and
git diff --check. The new regression test fails onthe original code and checks both sort directions, including zero values.
To reproduce the checks from the repository root:
cd web/app yarn install --frozen-lockfile yarn lingui compile yarn jest --runInBand --watch=false --no-coverage NODE_ENV=test yarn webpackBefore and after screenshots use the same isolated
MetricsTablefixture,sorted by P99 latency descending, with missing, positive, and zero values:
Fixes #3874
Signed-off-by: Mohammed Sharooq sharooqlavanya04@gmail.com