Repository navigation
feat: user predicates and aggregates (#180) - #16
Merged
Merged
Conversation
Copies minigraf-binding-template#9: MiniGrafUdfError, the MiniGrafPredicate / MiniGrafAggregate / MiniGrafAccumulator foreign traits, MiniGrafDb.registerPredicate / registerAggregate over the core's try_register_*, and handle locks that only clone the Minigraf. A throwing callback fails the query with QRY-014. Pins core v3 at 02243f16. The consumer contract gains a predicate, an aggregate and a throwing step (QRY-014); README gains "User functions". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Urda7FD9CYYoxdeGGJa11x
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UDF registration for Android, project-minigraf/minigraf#180 PR 5 (plan steps 17–20).
src/lib.rs: minigraf-binding-template#9's code, applied unchanged (thislib.rswas identical to the Java binding's before its #180 PR):MiniGrafUdfException(+From<UnexpectedUniFFICallbackError>), theMiniGrafPredicate/MiniGrafAggregate/MiniGrafAccumulatorwith_foreigntraits,registerPredicate/registerAggregateovertry_register_*, handle locks that only clone theMinigraf, and the template's Rust tests (44 pass).7c8c5540→02243f16(v3, #180 PR 1 + BrowserDb). #181 and #316 were already in this branch; #306 needs nothing here.consumer-test/tests/contract.kt, on the emulator):adult?predicate,productaggregate (360), a throwingstep→MiniGrafException.Querywith[QRY-014]and the exception's message.The generated Kotlin was checked for the names used (
MiniGrafPredicate.test,MiniGrafAccumulator.step/finish,MiniGrafUdfException.Failed,registerPredicate/registerAggregate).🤖 Generated with Claude Code
https://claude.ai/code/session_01Urda7FD9CYYoxdeGGJa11x