Repository navigation
docs: max-results counts only derived facts from v3.0.0 (#528) - #5
Merged
Merged
Conversation
Before v3.0.0 it also counted the database's own live facts, so rule queries failed with INT-020 on databases with that many facts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
The v3 changelog's `wal_checkpoint_threshold(usize::MAX)` widened the diff page by 15px at 375px. The phone-width test passed locally only when it measured before the diff rendered; it now waits for the diff. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to project-minigraf/minigraf#534.
Before v3.0.0,
max_results/:max-resultsalso counted the database's own live facts, so rule queries failed withINT-020on databases with that many facts. From v3.0.0 it counts only facts the rules derive. Both versions are documented with@until/@since v3.0.0indatalog-reference.mdandperformance-tuning.md.Also fixes a phone-width failure that docs
mainhits too against current minigrafv3: the v3 CHANGELOG's inlinewal_checkpoint_threshold(usize::MAX)wideneddiff/?from=v2.0.4&to=v3.0.0by 15px at 375px. Inline code now usesoverflow-wrap: anywhere, and the phone-width test waits for the diff to render (it passed locally before only by measuring too early).🤖 Generated with Claude Code
https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h