Repository navigation
feat: override list, open options and prepared limit setters (minigraf#872) - #17
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7QouMzKp3tAWxgVsxRf
…f#872) Exposes core v3's override surface: an allow_overrides list with the default list read from core's Overridable::DEFAULTS, the transaction_chunk_facts and max_iterations open options, and the three PreparedQuery limit setters, each returning a new prepared query and leaving the receiver unchanged. Refs minigraf#872. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7QouMzKp3tAWxgVsxRf
Temporary: re-pinned to the v3 merge commit once minigraf#883 merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7QouMzKp3tAWxgVsxRf
adityamukho
force-pushed
the
feat/872-binding-overrides
branch
from
November 10, 2026 10:19
979f699 to
9771d28
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7QouMzKp3tAWxgVsxRf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings this binding up to core v3's override surface (minigraf#872).
OpenOptions.allow_overridestakes a list ofOverridable(MaxDerivedFacts,MaxResults,QueryMemoryLimit,MaxIterations). Absent, the defaults apply. A list replaces the defaults, and an empty list refuses every override keyword (API-025).overridable_defaults()returns core'sOverridable::DEFAULTS; nothing is written out again in the binding.OpenOptions.transaction_chunk_factsandOpenOptions.max_iterations.i64::MAXmeans no limit formax_iterations. A negative count isAPI-017. The log writer accepts the new fields too.MiniGrafPreparedQuery.with_max_derived_facts/with_query_memory_limit/with_max_iterationseach return a new prepared query (core'sPreparedQueryis nowClone) and leave the receiver unchanged.i64::MAXmeans no limit and a negative value isAPI-017. The setters are not gated byallow_overrides. A derived query keeps its database open.execute/query/prepare), a chunked transaction surviving a reopen,max_iterations1 →INT-020, each setter (INT-020/QRY-012, receiver unchanged, chaining, no-limit, negatives) and an open cursor surviving a derive.Overridable.defaults(MinigrafKit+Overrides.swift), tests inTests/swift/main.swift, and a consumer contract test. Not compiled locally (no Swift toolchain here); the macOS CI jobs are the first build.Pin.
Cargo.tomlpins cored9755c02, the v3 merge commit of project-minigraf/minigraf#883. Moving the pin from02243f16needed no other fix. The macOS jobs run onmacos-15(themacos-14runner was retired; fixed separately on v3).Refs project-minigraf/minigraf#872.
🤖 Generated with Claude Code
https://claude.ai/code/session_01H2a7QouMzKp3tAWxgVsxRf