Skip to content

Benchmark regression: checkpoint (main) #589

Closed as not planned
Closed as not planned

Description

@github-actions

Bencher flagged these benchmarks in the nightly run (checkpoint, main) on two runs in a row:

  • checkpoint/100k
  • checkpoint/1m

Branch: main
Run: https://github.com/project-minigraf/minigraf/actions/runs/38526373427
Previous run: https://github.com/project-minigraf/minigraf/actions/runs/38373154795

Please review the Bencher dashboard to confirm the regression.

Activity

  1. adityamukho commented on Oct 14, 2026

    @adityamukho
    Collaborator

    Not a regression. Two things are stacked here:

    1. The fix(db): stale WAL removed by checkpoint; usize::MAX threshold skips close-time save (#457, #476, v2.x backport) #540 step (same as Benchmark regression: open (main) #561/Benchmark regression: checkpoint (main) #562/Benchmark regression: open (main) #573/Benchmark regression: checkpoint (main) #574): checkpoint/100k went from ~4.5 ms to ~2.2 s and checkpoint/1m from ~41 ms to ~25 s at a861e55 (2026-10-11). Before fix(db): stale WAL removed by checkpoint; usize::MAX threshold skips close-time save (#457, #476, v2.x backport) #540 these fixtures were no-ops. The 30-run window from ci(bench): compare each run with the last 30 runs, not all history #568 is still absorbing that step.
    2. A slow runner on 2026-10-14: 100k went 2.2 s → 4.35 s and 1m went 25.1 s → 40.5 s between d604cc4 and d3e5ad1. The only change to src/benches/Cargo.* between those commits is the 2.0.5 → 2.0.6 version bump (fuzz(datalog_eval): skip inputs whose patterns join to a cross product (#575) #577 is fuzz-only; docs(claude): merge main into v3 once, at the v3.0.0 cut #583 is docs). Unrelated benches slowed by the same factor in the same run: query/point_entity/1k 1.75×, query/regex_filter/1k 1.8×, temporal_metadata/tx_time/1k 1.74×, aggregation/count_scale/1k 1.86×. The I/O-heavy checkpoint benches took the worst of it (up to 3× for checkpoint/after_1_fact/100k).

    If tomorrow's main run stays near 4 s / 40 s, I'll reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    performanceBenchmark performance regressions

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions