Skip to content

Benchmark regression: query #501

Closed as not planned
Closed as not planned

Description

@github-actions

Bencher flagged these benchmarks in the nightly run (query) on two runs in a row:

  • query/predicate_pushdown/100k

Run: https://github.com/project-minigraf/minigraf/actions/runs/37905466826
Previous run: https://github.com/project-minigraf/minigraf/actions/runs/37749964713

Please review the Bencher dashboard to confirm the regression.

Activity

  1. adityamukho commented on Oct 10, 2026

    @adityamukho
    Collaborator

    Not a regression. Same alert as #487, re-fired because Bencher's history for this benchmark still holds the pre-#445 ~195 ms runs.

    run commit time
    37592142842 (2026-10-07) 596bb59 721 ms
    37749964713 (2026-10-08) bb7423f 719 ms
    37905466826 (2026-10-09) 339b31f 746 ms

    Between bb7423f and 339b31f the only change under src/, benches/ and Cargo.* is the v2.0.4 version bump in Cargo.toml (the other commits are docs and test-only). The +3.8% is runner noise. The ~720 ms level is the correct baseline: the query returns 9,999 rows since #445, where it used to return 0 (see #487).

    Closing as not a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    performanceBenchmark performance regressions

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions