Skip to content

ci(bench): compare each run with the last 30 runs, not all history #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityamukho merged 1 commit into from
Oct 13, 2026
Merged

ci(bench): compare each run with the last 30 runs, not all history #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,12 @@ jobs:
continue-on-error: true
run: |
set -o pipefail
# The t-test compares a run with the last 30 runs of its branch, not
# all history. Without a window, a correct step change (#445's
# predicate_pushdown, #476's checkpoint and wal_replay fixtures) kept
# alerting for weeks; with 30, a lasting change alerts on about five
# runs (enough for the two-in-a-row issue below), then becomes the
# baseline.
# A branch other than main starts from main's history and thresholds.
start_point=()
if [ "$BENCH_REF" != main ]; then
Expand All @@ -258,6 +264,7 @@ jobs:
--testbed ubuntu-latest \
--threshold-measure latency \
--threshold-test t_test \
--threshold-max-sample-size 30 \
--threshold-upper-boundary ${{ matrix.threshold }} \
--err \
--adapter rust_criterion \
Expand Down
Loading