Repository navigation
feat(errors): PRS-083..PRS-107 replace user-facing INT-019 parse errors (#643) - #648
Merged
Merged
Conversation
…rs (#643) The parser's long-tail syntax and structure errors shared INT-019 with a "datalog parser: " prefix. Each user-reachable site now has its own Parser-category code with today's text, and parse_retract checks the fact arity itself (PRS-090, was INT-000 via Pattern::from_edn). The four unreachable invariant sites keep INT-019. ERROR_REFERENCE.md gets a row and section per code; the INT-019 section lists what replaced it. Plan steps 1-5 of docs/superpowers/plans/2026-10-20-643-grammar-verifier.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#643 PR 2 of the plan (
docs/superpowers/plans/2026-10-20-643-grammar-verifier.md, steps 1–5). Part of #643; no closing keyword.What
PRS-083–PRS-107, for the 24 user-reachableINT-019sites inparser.rsand the retract arity path. Message text is unchanged except thedatalog parser:prefix is gone.parse_retractchecks the fact length beforePattern::from_edn, so a retract fact without 3 elements isPRS-090(wasINT-000).INT-019.docs/ERROR_REFERENCE.md: a quick-reference row and a section per code; theINT-019section now says it is raised only by unreachable invariants and lists what replaced it.CHANGELOG.mdUnreleased → Breaking changes (the plan said "Changed"; Unreleased has no such heading). Bindings unaffected (ErrorCodeispub(crate); plan deviation 5).Tests
tests/error_codes_prs_test.rs: 26 new tests, each running its code's documented example, asserting code, Parser category, argument in the message and no old prefix; three throughprepare. 1646 tests (1636 passing, 10 ignored). CI's clippy command andcargo fmt --checkclean.Review
Codex (read-only, on the commit): no defects found.
🤖 Generated with Claude Code
https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT