Repository navigation
docs(perf): verify keyword pattern constants after #551 - #773
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#531 reported keyword pattern constants being cloned and hashed for every candidate fact. The streaming engine removed that matcher path. This documents the remaining query paths and records a fresh 100K/1M/10M envelope plus separate 1M selective-join and attribute-scan profiles.
The report distinguishes parser/planner conversion from stored-keyword normalization and the separate per-row expression-equality cost introduced by #744. That expression follow-up remains a draft. No engine, API, file-format or release changes.
Validation: the pinned v3 source builds on the bench machine; all 69 envelope records completed without errors or caps; independent scan-join row counts match at all scales; both profiles report zero lost samples; report-table/JSON consistency checks and
git diff --checkpass. No laptop builds/tests. Claude reviewed the spec, plan and final diff; findings were verified and corrected, and the focused recheck approved the result. Bench scratch source, target, fixtures and captures are removed after retaining local reports.Refs #531. Keep the issue open until the verification is reviewed.
The report explicitly records the evidence gap: post-run load files retained uptime rather than full active-process lists; the toolchain/governor readback is labeled post-run. No claim of an 8% A/B speedup is made.